Skip to content

fix: members_sorted schedule#4376

Merged
epipav merged 4 commits into
mainfrom
fix/reschedule-members-sorted-copy
Jul 26, 2026
Merged

fix: members_sorted schedule#4376
epipav merged 4 commits into
mainfrom
fix/reschedule-members-sorted-copy

Conversation

@epipav

@epipav epipav commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: anilb <epipav@gmail.com>
Copilot AI review requested due to automatic review settings July 22, 2026 09:36
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conventional Commits FTW!

@cursor

cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single cron schedule change with no SQL or schema changes; main effect is when members_sorted refreshes relative to other hourly Tinybird jobs.

Overview
Shifts the hourly Tinybird copy job for members_sorted from COPY_SCHEDULE 8 * * * * to 36 * * * * in members_sorted_copy_pipe.pipe. The pipe still does a full replace copy into members_sorted on the same cadence; only the run minute changes.

That datasource is what downstream activity-relations bucket clean/enrich copy pipes use for valid-member filtering (memberId IN (SELECT id FROM members_sorted)), so this is a timing/load-order tweak rather than a logic change.

Reviewed by Cursor Bugbot for commit dcf457e. Bugbot is set up for automated code reviews on this repo. Configure here.

@CLAassistant

CLAassistant commented Jul 22, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ gaspergrom
❌ epipav
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves the hourly members_sorted Tinybird refresh from minute 8 to minute 36.

Changes:

  • Updates the copy schedule to 36 * * * *.
  • PR title is missing the required (CM-XXX) JIRA key.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@epipav epipav changed the title fix: members_sorted schedule fix: members_sorted schedule Jul 22, 2026
@epipav
epipav requested a review from gaspergrom July 22, 2026 09:41
Copilot AI review requested due to automatic review settings July 22, 2026 10:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread services/libs/tinybird/pipes/members_sorted_copy_pipe.pipe
@gaspergrom

Copy link
Copy Markdown
Contributor

lgtm

Copilot AI review requested due to automatic review settings July 23, 2026 08:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

services/libs/tinybird/pipes/members_sorted_copy_pipe.pipe:26

  • This now runs after all hourly clean/enrich consumers, which read members_sorted at minutes :10–:26 to filter valid members (activityRelations_bucket_clean_enrich_copy_pipe_{0..9}.pipe; see bucketing-architecture.md:118-143). They will therefore process the previous hour's member snapshot. Keep this refresh before :10, or reschedule every dependent consumer after :36.
COPY_SCHEDULE 36 * * * *

Copilot AI review requested due to automatic review settings July 26, 2026 10:03
@epipav
epipav merged commit 3151db9 into main Jul 26, 2026
15 checks passed
@epipav
epipav deleted the fix/reschedule-members-sorted-copy branch July 26, 2026 10:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

services/libs/tinybird/pipes/members_sorted_copy_pipe.pipe:26

  • This now refreshes members_sorted after every hourly activityRelations_bucket_clean_enrich_copy_pipe_* consumer (scheduled at minutes 10–26) and after contributions_with_local_time at minute 33. Those jobs will therefore always read the previous hour's member snapshot, delaying bot/team-member filtering and profile updates by another cycle. Keep this producer before the earliest dependent copy, or move all dependent schedules after minute 36.
COPY_SCHEDULE 36 * * * *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants